Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from GAPI to gtoken + Bug Fix #20

Merged
merged 4 commits into from
Mar 26, 2015

Conversation

stephenplusplus
Copy link
Contributor

I switched the library to use gtoken to add support for a path to a p12 keyfile. It's also a more well maintained and documented codebase (and made by the one and only @ryanseys).

I also caught a couple of bugs, which I will point out with comments.

(RE: googleapis/google-cloud-node#458)

UserRefreshClient.super_.prototype.refereshToken_.call(this._refreshToken,
opt_callback);
UserRefreshClient.super_.prototype.refreshToken_.call(
this, this._refreshToken, opt_callback);

This comment was marked as spam.

assert.equal('http://foo', opts.scope);
done();
return {
getToken: function() {}
}

This comment was marked as spam.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.14%) to 91.92% when pulling 54dee6e on stephenplusplus:master into ec10a81 on google:master.

tbetbetbe added a commit that referenced this pull request Mar 26, 2015
Switch from GAPI to gtoken + Bug Fix
@tbetbetbe tbetbetbe merged commit 97cefdd into googleapis:master Mar 26, 2015
@ryanseys
Copy link
Contributor

Thanks @tbetbetbe. What's the timeline for getting a new npm version out with these changes?

@tbetbetbe
Copy link
Contributor

There should be a release at the end of this week.

On 27 March 2015 at 11:22, Ryan Seys notifications@github.com wrote:

Thanks @tbetbetbe https://github.com/tbetbetbe. What's the timeline for
getting a new npm version out with these changes?


Reply to this email directly or view it on GitHub
#20 (comment)
.

This email may be confidential or privileged. If you received this
communication by mistake, please don't forward it to anyone else (it may
contain confidential or privileged information), please erase all copies of
it, including all attachments, and please let the sender know it went to
the wrong person. Thanks.

@tbetbetbe
Copy link
Contributor

Done. I just released 0.9.4.

On 30 March 2015 at 08:58, Tim Emiola temiola@google.com wrote:

There should be a release at the end of this week.

On 27 March 2015 at 11:22, Ryan Seys notifications@github.com wrote:

Thanks @tbetbetbe https://github.com/tbetbetbe. What's the timeline
for getting a new npm version out with these changes?


Reply to this email directly or view it on GitHub
#20 (comment)
.

This email may be confidential or privileged. If you received this
communication by mistake, please don't forward it to anyone else (it may
contain confidential or privileged information), please erase all copies of
it, including all attachments, and please let the sender know it went to
the wrong person. Thanks.

This email may be confidential or privileged. If you received this
communication by mistake, please don't forward it to anyone else (it may
contain confidential or privileged information), please erase all copies of
it, including all attachments, and please let the sender know it went to
the wrong person. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants